ECUFlash - Getting close!

[AdrianG]

I have just tried and the trigger is not working for me either. I see this this in the logcfg.out which makes me think it's loading the conditions properly:

 action: start condition: defog,1.000000,==
trigger action: stop condition: defog,0.000000,==

My Config
Logcfg.out
A test log without the trigger to ensure defogger is working

It seems odd since others have been able to set theirs based on RPM just fine.

[steve99]

Originally Posted by AdrianG

I have just tried and the trigger is not working for me either. I see this this in the logcfg.out which makes me think it's loading the conditions properly:

 action: start condition: defog,1.000000,==
trigger action: stop condition: defog,0.000000,==

My Config
Logcfg.out
A test log without the trigger to ensure defogger is working

It seems odd since others have been able to set theirs based on RPM just fine.

Looks same as mine

RPM works

I even tried

conditionrpn = Defogger,0.5,>
action = start
conditionrpn = Defogger,0.5,<
action = stop

still just runs all the time maybe were trying to compare different number types ??

RPM is float
Defogger is Binary


;-------------triggers--------------- ;
; note that parameters must be previously defined ; before defining triggers using them ;
; triggers allow you to control when logging starts and stops ; this example sets up triggers such that logging only occurs
; when the engine is running (RPM > 0) ;
; triggers consist of a condition (a RPN expression using comparison operators)
; and an action. the RPN comparison operators match those in the C language: ;
; > < >= <= == != && || ;
; if the condition evaluates to a non-zero value, that action is taken

[AdrianG]

Funny, mine just wouldn't start logging when I hit the defogger. I will play with some different logic to see if that makes a difference next chance I get.

- AdrianG

[Td-d]

Let me check the code again - maybe it's only using 1 bit out of the entire byte (i.e. masked), that was the case in the older roms.

[Td-d]

Ok, looks like it is a bit, not the whole byte.

Define the defogger switch as follows, and see if it still triggers:

paramname = defogger_sw
paramid = 0xFFF89393
databits = 1
offsetbits = 5

If that doesn't work, try offsetbits at 6.

[AdrianG]

Originally Posted by Td-d

Ok, looks like it is a bit, not the whole byte.

Define the defogger switch as follows, and see if it still triggers:

paramname = defogger_sw
paramid = 0xFFF89393
databits = 1
offsetbits = 5

If that doesn't work, try offsetbits at 6.

Instead of using the offset wouldn't it be easier to just log address FFF89398? Or am I batshit crazy with no concept of memory addressing practices?



- AdrianG

[Td-d]

I guess that should work as well - the bit offset syntax comes from the P parameters actually, where the parameter is a set offset in a table.

[jprice130]

I've been experimenting with the logcfg.txt files that you guys have posted with my OP2 and am not having much luck getting any data that makes a lot of sense. I have the logcfg file on the main directory of my micro SD card and I'm able to get a successful logcfg out and logcfg csv file. However, many of the values don't make much sense. For instance, my IAM reads -4 for all rows and the RPM value ranges between .9 and 1.01. Many other values are really odd looking too. I have a C series ROM and am using the C series logcfg file that has been posted. Am I missing something else?

[AdrianG]

You probably have a different ROM, as different versions have different logging addresses. Mine is for ZA1JA01C, what's yours?

- AdrianG

[jprice130]

Mine is B01C. I thought the C is what mattered for the logcfg addresses. Guess not?

[AdrianG]

I guess not. I had 700C before and saw the same behavior.

- AdrianG

[jprice130]

Perhaps I'll try flashing a A01C rom and see how it goes. Thanks!

[steve99]

Originally Posted by Td-d

Ok, looks like it is a bit, not the whole byte.

Define the defogger switch as follows, and see if it still triggers:

paramname = defogger_sw
paramid = 0xFFF89393
databits = 1
offsetbits = 5

If that doesn't work, try offsetbits at 6.

Thanks I'll try it out soon, the wife has "stolen" the car

Well might be a while ....

[steve99]

Originally Posted by Td-d

Ok, looks like it is a bit, not the whole byte.

Define the defogger switch as follows, and see if it still triggers:

paramname = defogger_sw
paramid = 0xFFF89393
databits = 1
offsetbits = 5

If that doesn't work, try offsetbits at 6.

Hi,

Tried this with offset = 5 and 6 does not log defogger any more with this always "0" and obviously trigger no work. Suppose its got to be one of them will try1.2.3,4 ,7,8 and see

Not a big drama will go back to my RPM trigger.